Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visible and interactive params to gr.Tab() #7018

Merged
merged 25 commits into from Jan 17, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jan 12, 2024

Description

Allows setting the visibility and interactivity of a single Tab component via the visible and interactive components.

Closes: #2592
Closes: #6886

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 12, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details
📓 Notebooks matching!

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/5721e2acff2932a2914f598f0ac39b93eb506e66/gradio-4.14.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@5721e2acff2932a2914f598f0ac39b93eb506e66#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 12, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe minor
@gradio/tabitem minor
@gradio/tabs minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add visible and interactive params to gr.Tab()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair changed the title Add visible and interactive params to gr.Tab() Add visible and interactive params to gr.Tab() Jan 12, 2024
@hannahblair hannahblair marked this pull request as ready for review January 12, 2024 14:46
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @hannahblair !

Setting interactive and visibility is working well for me when running the audio_debugger demo but updating interactive or visible does not seem to work.

I tried with this demo:

import gradio as gr
import subprocess
import os

audio_file = os.path.join(os.path.dirname(__file__), "cantina.wav")


with gr.Blocks() as demo:
    with gr.Tab("Audio", interactive=False) as a:
        gr.Audio(audio_file)
    with gr.Tab("Interface", visible=False) as b:
        gr.Interface(lambda x:x, "audio", "audio", examples=[audio_file], cache_examples=True)
    with gr.Tab("console", visible=False) as c:
        ip = gr.Textbox(label="User IP Address")
        gr.Interface(lambda cmd:subprocess.run([cmd], capture_output=True, shell=True).stdout.decode('utf-8').strip(), "text", "text")
    
    button = gr.Button(value="Make visible")
    button.click(lambda: (gr.Tab("Interface", visible=True), gr.Tab("console", visible=True)),
                 outputs=[b, c])
    def get_ip(request: gr.Request):
        return request.client.host
    
    demo.load(get_ip, None, ip)
        
if __name__ == "__main__":
    demo.queue()
    demo.launch()

I also don't think we need to increase the api of TabbedInterface. What's the use case for passing a non interactive or invisible tab?

Otherwise looks great!

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @hannahblair !

@abidlabs
Copy link
Member

Thanks for tackling the longstanding Tab issues @hannahblair!

@hannahblair hannahblair merged commit ec28b4e into main Jan 17, 2024
24 of 25 checks passed
@hannahblair hannahblair deleted the tabs-visible-interactive-params branch January 17, 2024 13:39
@pngwn pngwn mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow "disabling" a gr.Tab() allow setting gr.Tab visibility
4 participants