Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run before_fn and after_fn for each generator iteration #7029

Merged
merged 9 commits into from Jan 22, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jan 15, 2024

Description

Closes: #7020
Closes: #6762

The issue is that the after_fn which sets in_event_listener to False was never run for the iterations of an async generator. This meant the component init run this line was not working properly.

To test, you can use the repro from the original issue:

import gradio as gr
Start = False

def change():
    global Start
    print(Start)
    if Start:
        Start = False
        return gr.Button(interactive=False)
    else:
        Start = True
        return gr.Button(interactive=True)

with gr.Blocks() as demo:
    with gr.Column():
        btn0 = gr.Button("btn0", interactive=False)
    demo.load(change, None, btn0, every=1)
    demo.queue()
    demo.launch(debug=True)

update_interactive

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 15, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/790541bf3fb90bb09cae1fd0794b753853caee88/gradio-4.15.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@790541bf3fb90bb09cae1fd0794b753853caee88#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 15, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Run before_fn and after_fn for each generator iteration

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton changed the title Run after_fn for async generators Run before_fn and after_fn for async generators Jan 18, 2024
@freddyaboulton freddyaboulton changed the title Run before_fn and after_fn for async generators Run before_fn and after_fn for each generator iteration Jan 18, 2024
@aliabid94
Copy link
Collaborator

is this ready for re-review?

@freddyaboulton
Copy link
Collaborator Author

@aliabid94 Yes !

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@freddyaboulton freddyaboulton merged commit ac73555 into main Jan 22, 2024
19 of 20 checks passed
@freddyaboulton freddyaboulton deleted the 7020-update-interactive-with-every branch January 22, 2024 17:57
@freddyaboulton
Copy link
Collaborator Author

Thanks for the review @aliabid94 !

@pngwn pngwn mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants