New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add STL 3D model support #7049
add STL 3D model support #7049
Conversation
🪼 branch checks and previews
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Thanks @Mon-ius ! I think this looks good to me! Tagging @dawoodkhan82 @hannahblair for quick review from them. |
Great! Some checks need external auth for vercel deploy failed, should not be a problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! tested, and works. It would be great, if you can update the model3D
demo to include a .stl
example.
@dawoodkhan82 No problem! I will update a new model3D demo with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mon-ius ! I added the stl file to the existing model3D demo as opposed to creating a new one. Will merge once CI passes!
@freddyaboulton Good Job! Cheers! |
Since V4 supports adding .STL file in examples path which can render correctly in the box. There is no need to limit ".stl" file in the accepted upload list.
Example code:
Adding STL support can contribute a lot to 3D print industry, without extra convert, people can play more seamless 🤗
For more details, see https://huggingface.co/spaces/MassiveDL/T3D