Update ruff to 0.1.13, enable more rules, fix issues #7061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
akx
force-pushed
the
update-ruff
branch
4 times, most recently
from
9ebcd46
to
6339112
Compare
akx
force-pushed
the
update-ruff
branch
2 times, most recently
from
7327a4b
to
12aa811
Compare
|
Rebased. Could e.g. @abidlabs take a look? |
|
Much appreciated @akx. Went through all of the changes and the look good to me! |
Merged
aliabid94
pushed a commit
that referenced
this pull request
Feb 4, 2024
* add changeset * Update ruff to version 0.1.13 * Correct ruff target version * Enable more Ruff rules and fix issues * Enable ARG and fix issues * Enable PL lints, fix issues --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Ruff from 0.1.7 to 0.1.13, enables a handful more rules and fixes the resulting issues.
The
ARGrules will prevent copy-paste typo bugs and brainfarts, since you'll instantly notice whether you've missed using an argument you might actually want to use.