Add a simpleimage template for custom components
#7129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/06c616103fcd6c36262b642b1b4940a95ffcad4b/gradio-4.16.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@06c616103fcd6c36262b642b1b4940a95ffcad4b#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
commented
Jan 26, 2024
| elif component.template in gradio._simple_templates.__all__: # type: ignore | ||
| module = "_simple_templates" | ||
| else: | ||
| def find_template_in_list(template, list_to_search): |
There was a problem hiding this comment.
It was bothering me that the parameter to --template was case sensitive. This change makes it case-insensitive
pngwn
reviewed
Jan 26, 2024
freddyaboulton
approved these changes
Jan 26, 2024
|
Thanks @freddyaboulton and @pngwn. I've made the changes and I'll go ahead and merge this in. I'll bother you later if it doesn't work as a template |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
SimpleImagetemplate as I think many users may want to template off of theImagecomponent to get the upload/drag + preview behavior, but the regularImagecomponent has a lot of extra functionality that is not needed (e.g. sharing to HF, support for multiple sources, various PIL-related preprocessing, the .select() event)I built
SimpleImageas a custom component myself so it works as a component, but I'm not sure if it can be used as a template or if I need to do something else besides place the files in the right place. Would appreciate any insights @freddyaboulton @pngwn