New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ParamViewer css #7130
Fix ParamViewer css #7130
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/f2989e6c6510b174480c24ced2f1879b9e63d3c4/gradio-4.15.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f2989e6c6510b174480c24ced2f1879b9e63d3c4#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
We should add some stories but will hold off until we agree on the final style. |
Demo i used to test: import gradio as gr
with gr.Blocks() as demo:
gr.Markdown("The `round()` function in Python takes two parameters")
gr.ParamViewer(
{
"number": {
"type": "int | float",
"description": "The number to round",
"default": None,
},
"ndigits": {
"type": "int",
"description": "The number of digits to round to",
"default": "0",
},
"shape": {
"type": "int",
"default": "0",
},
"shape_two": {"type": "float", "default": "0.0"},
}
)
if __name__ == "__main__":
demo.launch()
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @freddyaboulton!
Thanks for the help and review @pngwn ! |
Description
Fixes: #7111
The problem was that we were using
prefers-color-scheme
as opposed to the built-in theme variables. Rather than adding component specific css variables (we agreed to not do that anymore) I tried to recreate the existing style with the current theme variables. I think I got close but there may be some discrepancies. I think it'd be best to not introduce new theme variables though.Dark mode
Left is this pr, right is main for both
Light mode
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh