Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure gradio cc publish uploads the documentation space, if it exists. #7159

Merged
merged 5 commits into from Jan 25, 2024

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jan 25, 2024

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 25, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/15fe73ba798ac3fdf6c50da77f1f5a3c07b75bd5/gradio-4.15.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@15fe73ba798ac3fdf6c50da77f1f5a3c07b75bd5#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 25, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure gradio cc publish uploads the documentation space, if it exists.

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pngwn ! Left a couple of nits but works well.

gradio/cli/commands/components/publish.py Outdated Show resolved Hide resolved
gradio/cli/commands/components/publish.py Outdated Show resolved Hide resolved
gradio/cli/commands/components/publish.py Outdated Show resolved Hide resolved
@pngwn
Copy link
Member Author

pngwn commented Jan 25, 2024

Okay, addressed those comments.

Changed the package_name to use the source dir if it passed, . if it isn't, and fall back to the wheel if everything fails.

@pngwn
Copy link
Member Author

pngwn commented Jan 25, 2024

There was also a rogue backtick on the guide causing some formatting issues. I've fixed that here too.

@pngwn pngwn merged commit 6ee22dc into main Jan 25, 2024
13 checks passed
@pngwn pngwn deleted the cc-publish-docs branch January 25, 2024 19:03
@pngwn pngwn mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants