Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload tweak #7206

Merged
merged 6 commits into from Jan 29, 2024
Merged

Upload tweak #7206

merged 6 commits into from Jan 29, 2024

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jan 29, 2024

Description

  • Tiny css tweak to uplaod progress, to ensure it is always centered. Only an issue in custom components.
  • Add engines field for node and pnpm, to ensure people are using the correct versions.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 29, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/d338ffe864dfe5e7b6105c3264a03861f1caff31/gradio-4.16.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d338ffe864dfe5e7b6105c3264a03861f1caff31#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 29, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/upload patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Upload tweak

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn pngwn added the v: patch A change that requires a patch release label Jan 29, 2024
@pngwn
Copy link
Member Author

pngwn commented Jan 29, 2024

pnpm version in ci didn't satisfy the check 🙈

fixed now

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks @pngwn!

@pngwn pngwn merged commit 572e360 into main Jan 29, 2024
13 checks passed
@pngwn pngwn deleted the upload-tweak branch January 29, 2024 14:53
@pngwn pngwn mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants