Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure open reactivity in Accordion #7208

Merged
merged 2 commits into from Jan 29, 2024
Merged

Ensure open reactivity in Accordion #7208

merged 2 commits into from Jan 29, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jan 29, 2024

Description

This PR ensures the open value in gr.Accordion updates when programmatically updated.

Demo:

import gradio as gr


def show_tab_one():
    return [gr.Tab(visible=True), gr.Tab(visible=False), gr.Accordion(open=False)]

def show_tab_two():
    return [gr.Tab(visible=False), gr.Tab(visible=True), gr.Accordion(open=False)]

def show_all_tabs():
    return [gr.Tab(visible=True), gr.Tab(visible=True), gr.Accordion(open=False)]

with gr.Blocks() as demo:
    with gr.Row():
        with gr.Accordion("Menu. Click to open or close", open=False) as accordion:
            btn_1 = gr.Button(value="Show Tab One")
            btn_2 = gr.Button(value="Show Tab Two")
            btn_3 = gr.Button(value="Show All Tabs")

    with gr.Row():
        with gr.Tabs():
            with gr.Tab(label="Tab One", visible=False) as tab_one:
                gr.Markdown(value="Tab One")
            with gr.Tab(label="Tab two", visible=False) as tab_two:
                gr.Markdown(value="Tab two")
    btn_1.click(show_tab_one, inputs=None, outputs=[tab_one, tab_two, accordion])
    btn_2.click(show_tab_two, inputs=None, outputs=[tab_one, tab_two, accordion])
    btn_3.click(show_all_tabs, inputs=None, outputs=[tab_one, tab_two, accordion])

if __name__ == "__main__":
    demo.launch()

Closes: #7172

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 29, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/dc96d5de9b3da9fc560c172acced29147cb7947e/gradio-4.16.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@dc96d5de9b3da9fc560c172acced29147cb7947e#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 29, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/accordion minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure open reactivity in Accordion

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Thanks @hannahblair

@hannahblair hannahblair merged commit efacc7d into main Jan 29, 2024
15 checks passed
@hannahblair hannahblair deleted the accordion-open branch January 29, 2024 17:59
@pngwn pngwn mentioned this pull request Jan 29, 2024
@dwipper
Copy link

dwipper commented Jan 29, 2024

@hannahblair It works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatically open and close gr.Accordion
4 participants