Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single file upload display #7221

Merged
merged 6 commits into from Jan 30, 2024
Merged

Fix single file upload display #7221

merged 6 commits into from Jan 30, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jan 30, 2024

Description

Closes: #7212

EDIT: Fixed by @hannahblair ! Thank you so much.
This was a visual bug - the upload works correctly. I tried to add a story to catch this but it's not working. Is it cause of the i18n prop? cc @hannahblair @pngwn

image

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 30, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/e24b5a1d5123a6cd1123b75de428755021885fe6/gradio-4.16.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e24b5a1d5123a6cd1123b75de428755021885fe6#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 30, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/file patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix single file upload display

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@yvrjsharma
Copy link
Collaborator

This is working fine for me now, thanks @freddyaboulton !

@freddyaboulton freddyaboulton marked this pull request as ready for review January 30, 2024 19:51
@freddyaboulton
Copy link
Collaborator Author

Thank you so much for the help @hannahblair !

@abidlabs
Copy link
Member

LGTM, thanks for adding the test!

@freddyaboulton freddyaboulton merged commit cae05c0 into main Jan 30, 2024
20 checks passed
@freddyaboulton freddyaboulton deleted the 7212-file-upload-single branch January 30, 2024 20:05
@pngwn pngwn mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradio File component not functioning correctly for 'single' file count.
5 participants