chore: Change time format

[arian81]

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #7179

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

[gradio-pr-bot]

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	building...
	Website	building...
	Storybook	ready!	Storybook preview
🦄	Changes	detected!	Details

[gradio-pr-bot]

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
@gradio/audio	patch
@gradio/utils	patch
@gradio/video	patch
gradio	patch

With the following changelog entry.

chore: Change time format (thanks @jjshoots for the independent contribution).

⚠️ The changeset file for this pull request has been modified manually, so the changeset generation bot has been disabled. To go back into automatic mode, delete the changeset file.

Something isn't right?

• Maintainers can change the version label to modify the version bump.
• If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

[abidlabs]

Thanks @arian81! You addressed my suggestion from #7270 which was to extract the logic into a separate helper function, so this looks good.

As mentioned in #7270, there is actually one more instance of time formatting that needs to be fixed, which is here:

gradio/js/video/shared/Player.svelte

Line 80 in 21cfb0a

return `${minutes}:${_seconds}`;

[arian81]

Thanks @arian81! You addressed my suggestion from #7270 which was to extract the logic into a separate helper function, so this looks good.

As mentioned in #7270, there is actually one more instance of time formatting that needs to be fixed, which is here:

gradio/js/video/shared/Player.svelte

Line 80 in 21cfb0a

return `${minutes}:${_seconds}`;

I will change that instance. I had one question tho and that is why the formatting logic for video player different than the rest. Currently i didn't apply the same function to the video player because i'm not even sure which component is using that one. But it would nice if you could clarify this.

[abidlabs]

I believe its the static Video component that is using this. So if you were to do:

import gradio as gr

with gr.Blocks() as demo:
    gr.Video("test.mp4")
    
demo.launch()

you'll see that even with your changes, its still using the mm:ss format right now

[arian81]

I believe its the static Video component that is using this. So if you were to do:

import gradio as gr

with gr.Blocks() as demo:
    gr.Video("test.mp4")
    
demo.launch()

you'll see that even with your changes, its still using the mm:ss format right now

ok i changed that one to use the global function as well. Everything seems to be working now.

[pngwn]

Small nit but. looks good! Thanks @arian81 !

[arian81]

@abidlabs Something seems to be broken in the upload button causing the functional test to fail but I haven't changed that file.

[abidlabs]

I think that's just a flaky functional test we need to get under control, don't worry about it!

[abidlabs]

LGTM thanks @arian81!

[jjshoots]

Thanks for this everyone! Needed this to get something blocking on my end moving. :)