Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_label check to gr.Dataframe #7283

Merged
merged 4 commits into from Feb 2, 2024
Merged

Add show_label check to gr.Dataframe #7283

merged 4 commits into from Feb 2, 2024

Conversation

hannahblair
Copy link
Collaborator

Description

We weren't using the show_label param in the frontend in Dataframe. This PR fixes that and adds a story.

Closes: #7279

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@hannahblair hannahblair changed the title Add show_label check to gr.Dataframe Add show_label check to gr.Dataframe Feb 2, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 2, 2024

🪼 branch checks and previews

Name Status URL
Spaces building...
Website building...
Storybook ready! Storybook preview
Visual tests 2 failing tests Build review
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 2, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add show_label check to gr.Dataframe

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Feb 2, 2024

Thanks @hannahblair for the quick fix and @hysts for creating the issue (using the playground!)

@abidlabs abidlabs merged commit 757dba6 into main Feb 2, 2024
13 checks passed
@abidlabs abidlabs deleted the dataframe-label branch February 2, 2024 17:46
@pngwn pngwn mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_label=False doesn't work for gr.Dataframe
3 participants