Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with datatype setting in gr.Dataframe. Setting no longer dependent on col_count #7286

Merged
merged 3 commits into from Feb 2, 2024

Conversation

cswamy
Copy link
Contributor

@cswamy cswamy commented Feb 2, 2024

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #6066

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 2, 2024

🪼 branch checks and previews

Name Status URL
Spaces building...
Website ready! Website preview
🦄 Changes detecting...

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 2, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixes issue with datatype setting in gr.Dataframe. Setting no longer dependent on col_count

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@cswamy cswamy changed the title Fixes issue with datatype setting in gr.Dataframe. Setting not dependent anymore on col_count Fixes issue with datatype setting in gr.Dataframe. Setting no longer dependent on col_count Feb 2, 2024
@abidlabs
Copy link
Member

abidlabs commented Feb 2, 2024

Thanks @cswamy for another contribution! Quick note: as it stands, this would eliminate the ability to set column-by-column datatypes. Let me suggest a change

Edit: never mind, I didn't drink coffee this morning

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @cswamy!

@abidlabs abidlabs merged commit 0d36ac0 into gradio-app:main Feb 2, 2024
7 checks passed
@pngwn pngwn mentioned this pull request Feb 2, 2024
@cswamy cswamy deleted the issue-6066 branch February 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datatype="markdown" of gr.Dataframe is applied only up to the third column
3 participants