Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape triple quotes when creating space.py for custom components #7290

Merged
merged 2 commits into from Feb 5, 2024
Merged

Escape triple quotes when creating space.py for custom components #7290

merged 2 commits into from Feb 5, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Feb 2, 2024

Closes: #7239

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 2, 2024 •
edited

🪼 branch checks and previews

• Name Status URL
Spaces building...
Website ready! Website preview
🦄 Changes detecting...

@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Escape triple quotes when creating space.py for custom components

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?
  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

freddyaboulton
freddyaboulton approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abidlabs !

@abidlabs
Copy link
Member Author

abidlabs commented Feb 5, 2024

Thanks @freddyaboulton!

@abidlabs abidlabs merged commit db27df3 into main Feb 5, 2024
7 checks passed
@abidlabs abidlabs deleted the escape-triple-quotes branch February 5, 2024 18:06
@pngwn pngwn mentioned this pull request Feb 5, 2024
Merged
freddyaboulton pushed a commit that referenced this pull request Feb 9, 2024
@abidlabs @gradio-pr-bot @freddyaboulton
Escape triple quotes when creating space.py for custom components (#…
e72f529 
…7290)

* escape triple quotes when creating space.py for custom components

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@pngwn pngwn Awaiting requested review from pngwn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gradio cc publish publishes a broken space if the demo app file contains """
3 participants
@abidlabs @gradio-pr-bot @freddyaboulton