Add gr.Image interaction test + gr.ImageEditor interaction test improvement
#7309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…radio into story-source-select
hannahblair
changed the title
gr.Imagegr.Image
hannahblair
changed the title
gr.Imagegr.Image interaction test + gr.ImageEditor interaction test improvement
abidlabs
reviewed
Feb 6, 2024
| @@ -51,6 +51,9 @@ | |||
|
|
|||
| <Story | |||
| name="Image Editor Interactions" | |||
| parameters={{ | |||
| diffThreshold: 0.1 | |||
abidlabs
reviewed
Feb 6, 2024
| on:click={select_source} | ||
| aria-label={mode === "image" ? "capture photo" : "start recording"} | ||
| aria-label="select input source" |
|
Let me merge this in so that tests on other PRs are not flaky |
Merged
freddyaboulton
pushed a commit
that referenced
this pull request
Feb 9, 2024
…mprovement (#7309) * add source selection interaction story * add changeset * add source selection e2e test * add changeset * add diff threshold to imageeditor story * remove redundant <button> * add changeset * typo * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an interaction test to assert the source selection in
gr.Imagebehaves as expected. Note, we can't do a storybook story for this because storybook doesn't provide access to the browser context to allow us to access the permissions API and grant camera access - but we can do this with playwright.Closes: #7308
Closes: #7310
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh