Fix processing_utils.save_url_to_cache() to follow redirects when accessing the URL
#7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…ccessing the URL
whitphx
force-pushed
the
url-cache-follow-redirects
branch
from
efd314d
to
03909c2
Compare
…adio into url-cache-follow-redirects
freddyaboulton
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
I think the only other place where we need to make this change is validate_url in gradio/utils.py. Other than that, looks great! Thanks @whitphx !
Merged
freddyaboulton
pushed a commit
that referenced
this pull request
Feb 9, 2024
…ccessing the URL (#7322) * Fix `processing_utils.save_url_to_cache()` to follow redirects when accessing the URL * add changeset * follow more redirects * format * add changeset * add test * validate urls --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #7247
When testing this PR, remove your local Gradio cache first.
httpxmethods don't follow URL redirects by default.Refs:
In this PR, only
processing_utils.save_url_to_cache()is modified to address #7247 , but do you think if there are some other places where the same fix should be applied?