fix-tests

[pngwn]

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

[gradio-pr-bot]

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	failed!	Details
🦄	Changes	detecting...

---

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/cc76deb08dc62e6a90e978340839f0be4a9d83b2/gradio-4.19.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@cc76deb08dc62e6a90e978340839f0be4a9d83b2#subdirectory=client/python"

[gradio-pr-bot]

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
@gradio/app	patch
@gradio/lite	patch
@gradio/tootils	patch
@gradio/wasm	patch
gradio	patch

• Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

fix-tests

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

• Maintainers can change the version label to modify the version bump.
• If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

[whitphx]

I think Lite's E2E tests should be run on a separate CI job because the functional tests take a long time and randomly fail.

[pngwn]

I think Lite's E2E tests should be run on a separate CI job because the functional tests take a long time and randomly fail.

This is something we should fix rather than adding complexity to the Ci to workaround. I am aware of that failing test and looking into it.

[whitphx]

That's correct about the random failures, but parallel execution is a right solution for long-running tests in general, not a workaround. It's not complex.

[whitphx]

Anyway, the test passed after several trials 👍 .
The job failed because the do check step fails as it refers to the changes job which is temporarily removed in this PR.

[whitphx]

Commit 32154f3 to trigger the CI using the changes in this PR. Will revert it after confirming it works.

Update: Reverted. It worked well (https://github.com/gradio-app/gradio/actions/runs/7991559044/job/21823007428).

[pngwn]

I mentioned this somewhere else, but we don't need to run all of the functional tests, most of them test similar code paths and don't really give us much additional info.

The test I added via playwright's test match are sufficient as those tests include the kitchen sink which covers the majority of the API surface area. The lite tests are significantly slower than the normal functional tests, so as we add more it will make things much worse than expected and it is much easier to maintain and include list than an ignore list.

This also means we can get rid of the lite specific flags in the test code.

If you think there are any specific tests worth running against lite then feel free to include those as well.

We can review this over time if specific bugs seem to recur.

[whitphx]

@pngwn Ok, done.

If it's ok, revert 95b2ee6 before merging.

[whitphx]

Thanks!