Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure Dataframes in background tabs are visible when the tab is selected #7354

Merged
merged 22 commits into from Feb 9, 2024

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Feb 8, 2024

Closes #7349.

See comment below for details.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 8, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/061b0d62ea70201038830a5d9bf7e70d4963140f/gradio-4.17.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@061b0d62ea70201038830a5d9bf7e70d4963140f#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 8, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

ensure Dataframes in background tabs are visible when the tab is selected

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn pngwn changed the title Add vite config recalculate virtual table if tab visibility changes Feb 8, 2024
@pngwn pngwn marked this pull request as draft February 8, 2024 16:15
@pngwn
Copy link
Member Author

pngwn commented Feb 9, 2024

Alright, I think I have this working now:

Old:

Screen.Recording.2024-02-08.at.14.38.32.mov

New:

Screen.Recording.2024-02-09.at.15.41.48.mov

The issue was to do with heights not being reported correctly (or at all) for certain devices. I do not know why. It will remain forever a mystery.

I changed how we become notified of dimensions changes and that seems to have done the trick.

The CSS being broken is a separate issue.

If you have access to a device that didn't work then please try this preview: https://pngwn-7349-df-repro-fix.hf.space/

@pngwn pngwn marked this pull request as ready for review February 9, 2024 15:54
@pngwn pngwn changed the title recalculate virtual table if tab visibility changes ensure Dataframes in background tabs are visible when the tab is selected Feb 9, 2024
@pngwn
Copy link
Member Author

pngwn commented Feb 9, 2024

This PR represents the least fun I've had in years. I might frame it as a reminder.

@pngwn
Copy link
Member Author

pngwn commented Feb 9, 2024

Those test failures are weird but i can repro locally.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant @pngwn thanks for taking care of this!

Merged origin/main into Add vite config
@pngwn
Copy link
Member Author

pngwn commented Feb 9, 2024

work pls

@pngwn pngwn enabled auto-merge (squash) February 9, 2024 18:22
@pngwn pngwn merged commit a7fa47a into main Feb 9, 2024
8 checks passed
@pngwn pngwn deleted the add-vite-config branch February 9, 2024 18:23
@pngwn pngwn mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataframe appears empty on mobile
3 participants