New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure Dataframes in background tabs are visible when the tab is selected #7354
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/061b0d62ea70201038830a5d9bf7e70d4963140f/gradio-4.17.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@061b0d62ea70201038830a5d9bf7e70d4963140f#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Alright, I think I have this working now: Old: Screen.Recording.2024-02-08.at.14.38.32.movNew: Screen.Recording.2024-02-09.at.15.41.48.movThe issue was to do with heights not being reported correctly (or at all) for certain devices. I do not know why. It will remain forever a mystery. I changed how we become notified of dimensions changes and that seems to have done the trick. The CSS being broken is a separate issue. If you have access to a device that didn't work then please try this preview: https://pngwn-7349-df-repro-fix.hf.space/ |
This PR represents the least fun I've had in years. I might frame it as a reminder. |
Those test failures are weird but i can repro locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant @pngwn thanks for taking care of this!
Merged origin/main into Add vite config
merged from upstream
b09f510
to
21d6c6c
Compare
work pls |
Closes #7349.
See comment below for details.