Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow applying @media, @keyframes and @import in custom CSS #7395

Merged
merged 16 commits into from Feb 12, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Feb 12, 2024

Description

Our custom CSS logic was only applying CSS rules with the type CSSStyleRule, which meant that other rule types including CSSMediaRule and CSSKeyframesRule weren't being applied. This fixes that, and adds a demo and an e2e test to ensure all three rules are applied.

Closes: #7390

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@hannahblair hannahblair marked this pull request as ready for review February 12, 2024 15:10
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 12, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/e41ad4edde5cff58f561cf092e23778ab7a67035/gradio-4.18.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e41ad4edde5cff58f561cf092e23778ab7a67035#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 12, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow applying @media, @keyframes and @import in custom CSS

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

js/app/src/css.ts Outdated Show resolved Hide resolved
@dawoodkhan82 dawoodkhan82 self-requested a review February 12, 2024 17:47
@dawoodkhan82
Copy link
Collaborator

Otherwise lgtm!

@hannahblair hannahblair changed the title Allow applying @media and @keyframes in custom CSS Allow applying @media,@keyframes and @import in custom CSS Feb 12, 2024
@hannahblair hannahblair changed the title Allow applying @media,@keyframes and @import in custom CSS Allow applying @media, @keyframes and @import in custom CSS Feb 12, 2024
@hannahblair hannahblair merged commit 46b4568 into main Feb 12, 2024
8 checks passed
@hannahblair hannahblair deleted the apply-media-css branch February 12, 2024 23:39
@pngwn pngwn mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS rules in @media blocks are not applied
3 participants