New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow applying @media
, @keyframes
and @import
in custom CSS
#7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahblair
requested review from
abidlabs,
aliabid94,
dawoodkhan82,
pngwn and
freddyaboulton
February 12, 2024 15:10
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/e41ad4edde5cff58f561cf092e23778ab7a67035/gradio-4.18.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e41ad4edde5cff58f561cf092e23778ab7a67035#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…into apply-media-css
hannahblair
commented
Feb 12, 2024
Otherwise lgtm! |
dawoodkhan82
approved these changes
Feb 12, 2024
hannahblair
changed the title
Allow applying
Allow applying Feb 12, 2024
@media
and @keyframes
in custom CSS@media
,@keyframes
and @import
in custom CSS
hannahblair
changed the title
Allow applying
Allow applying Feb 12, 2024
@media
,@keyframes
and @import
in custom CSS@media
, @keyframes
and @import
in custom CSS
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our custom CSS logic was only applying CSS rules with the type
CSSStyleRule
, which meant that other rule types includingCSSMediaRule
andCSSKeyframesRule
weren't being applied. This fixes that, and adds a demo and an e2e test to ensure all three rules are applied.Closes: #7390
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh