Model3D Gaussian Splatting #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/a450f26f19911068487c3389cbcc8e1f10104549/gradio-4.18.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a450f26f19911068487c3389cbcc8e1f10104549#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
|
|
Hmm, is this really something we want in core? This feel specialised enough to be its own custom component. |
pngwn
reviewed
Feb 13, 2024
pngwn
reviewed
Feb 13, 2024
pngwn
requested changes
Feb 13, 2024
dylanebert
force-pushed
the
model3d-gaussian-splatting
branch
from
e6638ea
to
964953b
Compare
pngwn
reviewed
Feb 13, 2024
|
@dylanebert I think we are good to move ahead with this. |
add gsplat implementation run formatting move example .splat and .ply to url add changeset dispose of renderer on unmount notebook
dylanebert
force-pushed
the
model3d-gaussian-splatting
branch
from
f0cf4e1
to
2037c9d
Compare
|
I believe all comments have now been addressed :) |
pngwn
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Looks great! Thanks @dylanebert for adding this and addressing all of those comments!
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Canvas3DGSsvelte component that mirrorsCanvas3D, then using a conditional on the file extensionConsiderations
.plysupport is later added for meshes, then inferring mesh vs. splat from the extension alone may not be sufficient.Closes: #7405
cc @abidlabs @hysts