Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File Explorer interactivity #7417

Merged
merged 6 commits into from Feb 14, 2024
Merged

Conversation

aliabid94
Copy link
Collaborator

Fixes #6627

When FileExplorer is not interactive, checkboxes are hidden

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 14, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/50d55cf70a408d456a67019d07ed8c7ae2e87661/gradio-4.18.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@50d55cf70a408d456a67019d07ed8c7ae2e87661#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 14, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix File Explorer interactivity

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Feb 14, 2024

Thanks @aliabid94! One thing to think about -- usually, the non-interactive version of a component is used to display the value of a component. Here, the value are the selected files, however, these are not displayed at all when interactive=False. Would it make sense to just show the selected files with checkboxes, but not let users modify them?

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@aliabid94
Copy link
Collaborator Author

Hmm I see your point. Will revert. Visually I still think it's hard to tell a checkbox is disabled.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool looks good then.

@aliabid94 aliabid94 merged commit 314ccfa into main Feb 14, 2024
7 checks passed
@aliabid94 aliabid94 deleted the fix_file_explorer_interactivity branch February 14, 2024 20:44
@pngwn pngwn mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants