Prevent timing attacks to guess Gradio passwords #7440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abidlabs
requested review from
aliabid94,
aliabd,
dawoodkhan82,
pngwn,
hannahblair,
hysts and
freddyaboulton
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/6601070af0bc8955e94479ad66aa426ba0215591/gradio-4.19.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@6601070af0bc8955e94479ad66aa426ba0215591#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
gradio/route_utils.py
Outdated
|
|
||
|
|
||
| def compare_passwords_securely(input_password: str, correct_password: str) -> bool: | ||
| return hmac.compare_digest(input_password, correct_password) |
There was a problem hiding this comment.
I think this only works for ASCII characters. We should convert to bytes first something like input_password.encode("utf-8")
abidlabs
commented
Feb 15, 2024
|
|
||
|
|
||
| def compare_passwords_securely(input_password: str, correct_password: str) -> bool: | ||
| return hmac.compare_digest(input_password.encode(), correct_password.encode()) |
There was a problem hiding this comment.
Default encoding is utf-8
|
Done @freddyaboulton if you could take another look! |
freddyaboulton
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we compare passwords is vulnerable to timing attack to guess the password. This PR uses
hmacto prevent that, as described here: https://sqreen.github.io/DevelopersSecurityBestPractices/timing-attack/python