Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch change event for file explorer #7441

Merged
merged 12 commits into from
Feb 16, 2024
Merged

Dispatch change event for file explorer #7441

merged 12 commits into from
Feb 16, 2024

Conversation

aliabid94
Copy link
Collaborator

Fixes: #7432

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 15, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/599a0ec04c8ba24f4ca404163c21647249c38928/gradio-4.19.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@599a0ec04c8ba24f4ca404163c21647249c38928#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 15, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/fileexplorer patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Dispatch change event for file explorer

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @freddyaboulton!

@dawoodkhan82 dawoodkhan82 self-requested a review February 15, 2024 21:12
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just updated the branch to see if the tests pass, they are finae locally so not sure what the issue is. Thanks @aliabid94!

@aliabid94 aliabid94 merged commit f52cab6 into main Feb 16, 2024
8 checks passed
@aliabid94 aliabid94 deleted the file_explorer_change branch February 16, 2024 18:03
@pngwn pngwn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileExplorer change event not working in 4.19.0
6 participants