Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fix in #7444 (Block /file= filepaths that could expose credentials on Windows) more general #7453

Merged
merged 7 commits into from Feb 16, 2024

Conversation

abidlabs
Copy link
Member

Slightly more general fix for #7444 to handle IPFS and other crazy formats

@abidlabs abidlabs changed the title Make fix in #7444 mor general Make fix in #7444 more general Feb 16, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 16, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a0480472e3744cf9821dd2150ca96edce47a9868/gradio-4.19.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a0480472e3744cf9821dd2150ca96edce47a9868#subdirectory=client/python"

@abidlabs abidlabs requested a review from pngwn February 16, 2024 16:53
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 16, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Make fix in #7444 (Block /file= filepaths that could expose credentials on Windows) more general

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs changed the title Make fix in #7444 more general Make fix in #7444 (Block /file= filepaths that could expose credentials on Windows) more general Feb 16, 2024
@abidlabs abidlabs added the v: patch A change that requires a patch release label Feb 16, 2024
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for hardening this @abidlabs!

@abidlabs
Copy link
Member Author

Ok so python-multipart just released a new version (0.0.9) which changed some of the type annotations, which was causing our typecheck to fail. I've updated the typechecks, everything should pass now and I'll go ahead and merge.

@abidlabs abidlabs enabled auto-merge (squash) February 16, 2024 18:09
@abidlabs abidlabs merged commit ba747ad into main Feb 16, 2024
7 checks passed
@abidlabs abidlabs deleted the followup branch February 16, 2024 18:09
@pngwn pngwn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants