Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab select fix #7470

Merged
merged 13 commits into from Feb 21, 2024
Merged

Tab select fix #7470

merged 13 commits into from Feb 21, 2024

Conversation

aliabid94
Copy link
Collaborator

@aliabid94 aliabid94 commented Feb 17, 2024

Fixes issue with tab.select listener not working when it's visiblity is toggled:

Fixes: #7449 Fixes: #7189

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/143b4dc74ae9f2fb95790973bbe9077a2c40cefa/gradio-4.19.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@143b4dc74ae9f2fb95790973bbe9077a2c40cefa#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 17, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/tabs patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Tab select fix

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair
Copy link
Collaborator

Tested with the demo in #7449 and works great. Thanks for fixing this @aliabid94!

js/tabs/shared/Tabs.svelte Outdated Show resolved Hide resolved
@abidlabs
Copy link
Member

Thanks @aliabid94! We've increased what's possible with gr.Tabs recently, so it'd be great to add an E2E test for tabs to catch any other regressions that might pop up. Would you be able to create one testing these kinds of workflows:

  • Ensuring that tabs interactivity can be toggled on and off
  • Ensuring that tabs visibility can be toggled on and off
  • Ensuring that toggling visibility does not lose the event listeners
  • Ensuring that tabs that are not interactive cannot be navigated to

@aliabid94
Copy link
Collaborator Author

ok added all the functional tests @abidlabs

@abidlabs
Copy link
Member

Cool thanks! We should be good to merge then once they pass

@aliabid94 aliabid94 merged commit ba3ec13 into main Feb 21, 2024
8 checks passed
@aliabid94 aliabid94 deleted the fix_tab_id branch February 21, 2024 23:27
@pngwn pngwn mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants