Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Invalid file_type breaks drag and drop #7559

Merged
merged 14 commits into from Mar 5, 2024
Merged

Fixes: Invalid file_type breaks drag and drop #7559

merged 14 commits into from Mar 5, 2024

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Fixes: Invalid file_type breaks drag and drop

import gradio as gr

with gr.Blocks() as app:
  gr.File(file_types=["pdf"]) # Can't drag and drop files, can select files.
  gr.File(file_types=[".pdf"]) # Can both drag and drop and select files.

app.launch()

Closes: #7556

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 28, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook failed! Details
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/61e2077da32088017b99f2d1556db50f9d25fda8/gradio-4.19.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@61e2077da32088017b99f2d1556db50f9d25fda8#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 28, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/file patch
@gradio/upload patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixes: Invalid file_type breaks drag and drop

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Nice @dawoodkhan82, could we add a test for this?

@hannahblair
Copy link
Collaborator

Tested and looks good!

@dawoodkhan82 dawoodkhan82 merged commit 26356a6 into main Mar 5, 2024
6 of 7 checks passed
@dawoodkhan82 dawoodkhan82 deleted the file-type branch March 5, 2024 21:52
@pngwn pngwn mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid file_types breaks drag and drop in gr.File()
4 participants