Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes method to resolve the root URLs #7565

Merged
merged 4 commits into from Mar 4, 2024
Merged

Fixes method to resolve the root URLs #7565

merged 4 commits into from Mar 4, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Feb 29, 2024

There was a mistake in how we were updating the root url, so that they weren't being updated correctly after the first time, which was leading to issues like this: #7531

Test with:

import gradio as gr

with gr.Blocks() as demo:
    gr.Audio("https://file-examples.com/storage/fe98e6ab1965df346a899de/2017/11/file_example_MP3_700KB.mp3")
    
demo.launch(share=True)

Fixes: #7531
Fixes: #7566

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 29, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/c167a1fa84c3534ad953f3739f858bb9e91d18e8/gradio-4.19.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c167a1fa84c3534ad953f3739f858bb9e91d18e8#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 29, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixes method to resolve the root URLs

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@@ -361,13 +361,13 @@ def test_add_root_url():
new_expected = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was wrong which is why we didn't notice this bug sooner (this is what I get for not paying close enough attention to GH Copilot's output)

@yvrjsharma
Copy link
Collaborator

This fixes #7566 as well. Thanks @abidlabs

@yvrjsharma yvrjsharma self-assigned this Mar 4, 2024
@abidlabs abidlabs requested a review from yvrjsharma March 4, 2024 15:48
Copy link
Collaborator

@yvrjsharma yvrjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #7566 Thanks @abidlabs !

@abidlabs abidlabs merged commit 1c22123 into main Mar 4, 2024
11 checks passed
@abidlabs abidlabs deleted the root-fix branch March 4, 2024 15:52
@pngwn pngwn mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image viewer isnt working for filepath gr.Audio blocked by nginx
3 participants