Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed error message for wasm_utils.get_registered_app() #7572

Merged
merged 3 commits into from Mar 18, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Feb 29, 2024

Description

Detailed error message to make debugging easier.

@whitphx whitphx added the gradio-lite Related to the @gradio/lite library label Feb 29, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 29, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/9b2e3e03ea9919481bcd1ab8202c7cd5bf13aa2b/gradio-4.21.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9b2e3e03ea9919481bcd1ab8202c7cd5bf13aa2b#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Feb 29, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Detailed error message for wasm_utils.get_registered_app()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx marked this pull request as ready for review March 1, 2024 01:51
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we had this on hold because ui tests was failing. but everything lgtm now! thanks @whitphx

@abidlabs
Copy link
Member

Amazing thanks @whitphx and thanks @aliabd for reviewing!

@abidlabs abidlabs merged commit 7d3c868 into main Mar 18, 2024
7 checks passed
@abidlabs abidlabs deleted the wasm-app-not-found-error branch March 18, 2024 14:35
@pngwn pngwn mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradio-lite Related to the @gradio/lite library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants