Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Lite custom element to initialize the app in the connected callback and dispose the app in the disconnected callback #7577

Merged
merged 4 commits into from Mar 8, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Mar 1, 2024

Description

The custom element <gradio-lite /> is not working for example when it's dynamically created by Svelte.
Ref: https://stackoverflow.com/q/63066330/13103190 (actually, Svelte uses createElement internally to create DOMs)

…llback and dispose the app in the disconnected callback
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 1, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/e4e790e1bec53842a192bfadfa1cc863c36f9e93/gradio-4.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e4e790e1bec53842a192bfadfa1cc863c36f9e93#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 1, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix the Lite custom element to initialize the app in the connected callback and dispose the app in the disconnected callback

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @whitphx!

@abidlabs
Copy link
Member

abidlabs commented Mar 8, 2024

Likewise I'll get this in for the release! cc @aliabd

@abidlabs abidlabs merged commit 7c66a29 into main Mar 8, 2024
7 of 8 checks passed
@abidlabs abidlabs deleted the lite-custom-element-callbacks branch March 8, 2024 20:04
@pngwn pngwn mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants