Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent additional paths that can trigger credential leakage on Windows #7598

Merged
merged 5 commits into from Mar 5, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Mar 4, 2024

No description provided.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 4, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/2c6f99adbff743c1a3176776a4ace15158c518dc/gradio-4.19.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2c6f99adbff743c1a3176776a4ace15158c518dc#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 4, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Prevent additional paths that can trigger credential leakage on Windows

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @abidlabs ! Thanks for the fix. I think this should be a patch instead of a minor though.

@abidlabs
Copy link
Member Author

abidlabs commented Mar 5, 2024

Thanks @freddyaboulton! yup

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 5, 2024
@abidlabs abidlabs merged commit d3384cb into main Mar 5, 2024
7 checks passed
@abidlabs abidlabs deleted the harden branch March 5, 2024 18:23
@pngwn pngwn mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants