New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent audio speeding up when trimming #7599
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/52578b38edbb1973ba830f59a9e2ca7b81dc7b49/gradio-4.19.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@52578b38edbb1973ba830f59a9e2ca7b81dc7b49#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @hannahblair nice fix!
@hannahblair Yes, it seems to be fixed by this PR! Thanks! |
Description
This PR changes the way we convert the audio buffer we get from the audio component to WAV format. The function should now interleave the audio samples correctly so the audio data matches what the audio component expects for stereo or multi-channel WAV files.
This also fixes the background of the trim region which got lost at some point (if the option isn't provided as a param)
Note, I think this should close #6336 but I can't be sure as I can't repro it
Tested with:
Closes: #7592
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh