Fix flagged files and ensure that flagging_mode="auto" saves output components as well #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/3c7625eb19fac7959b60abf8b65a1d319b7a82e8/gradio-4.21.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3c7625eb19fac7959b60abf8b65a1d319b7a82e8#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
changed the title
abidlabs
commented
Mar 14, 2024
| @@ -156,9 +155,6 @@ def postprocess(self, value: tuple[str] | str | None) -> None | str: | |||
| else: | |||
| return value.strip() | |||
|
|
|||
| def flag(self, payload: Any, flag_dir: str | Path = "") -> str: | |||
There was a problem hiding this comment.
Not needed, the base class takes care of this.
abidlabs
commented
Mar 14, 2024
| @@ -94,13 +93,6 @@ def example_payload(self) -> Any: | |||
| def example_value(self) -> Any: | |||
| return {"foo": "bar"} | |||
|
|
|||
| def flag( | |||
There was a problem hiding this comment.
Not needed anymore either, the base class takes care of this.
abidlabs
commented
Mar 14, 2024
gradio/flagging.py
Outdated
| @@ -127,8 +127,8 @@ def image_classifier(inp): | |||
| Guides: using-flagging | |||
| """ | |||
|
|
|||
| def __init__(self): | |||
| pass | |||
| def __init__(self, simplify_files: bool = True): | |||
There was a problem hiding this comment.
We add this parameter because example caching also uses this method, and there, we actually do want to keep the full file data
freddyaboulton
approved these changes
Mar 14, 2024
|
Thanks @freddyaboulton |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components with
FileDatavalues were being saved in their entirety in the CSV files. This PR makes it so that only the filepaths are saved. I considered modifying theflag()function, but that would lead to incompatibility with custom components and make it more complex for custom component developers to write their ownflag()functions so instead I do some postprocessing after the.flag()function has been called.Closes: #7701
Also fixed a long-standing issue where if
flagging_mode="auto", the output was not being saved.Closes: #3441
I set this to
minorbecause although these are technically bugfixes, the behavior has been this way for such a long time, some users might see this as a breaking change.