Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Storybook 8 #7743

Merged
merged 12 commits into from Mar 19, 2024
Merged

Migrate to Storybook 8 #7743

merged 12 commits into from Mar 19, 2024

Conversation

hannahblair
Copy link
Collaborator

Description

Migrate to Storybook 8 (yay, we can remove react and react-dom)

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 19, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/17b0c6cf006c4a3ffb2d367389bd47c50b88645d/gradio-4.21.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@17b0c6cf006c4a3ffb2d367389bd47c50b88645d#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 19, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/radio patch
@gradio/storybook patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Migrate to Storybook 8

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn
Copy link
Member

pngwn commented Mar 19, 2024

niiiice

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 19, 2024
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a patch but otherwise LGTM. Thanks @hannahblair for taking care of this!

@abidlabs
Copy link
Member

abidlabs commented Mar 19, 2024

Going to merge this in so that we can rebase the other pr. ty @hannahblair!

@abidlabs abidlabs merged commit a2badf1 into main Mar 19, 2024
7 of 8 checks passed
@abidlabs abidlabs deleted the update-storybook branch March 19, 2024 18:22
@pngwn pngwn mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants