Fail CI if lint or typecheck fails #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/c4e259cd749ae4de48bc96c9b0d877d58a35230d/gradio-4.22.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c4e259cd749ae4de48bc96c9b0d877d58a35230d#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Let me also fix the error in multimodal textbox python file |
|
Ok cleaned up the typing in the multimodaltextbox component as well. |
| ) -> dict[str, str | list] | None: | ||
| def _preprocess_file(self, path: str) -> str: | ||
| file_name = path | ||
| file = tempfile.NamedTemporaryFile(delete=False, dir=self.GRADIO_CACHE) |
There was a problem hiding this comment.
How come we need this now?
There was a problem hiding this comment.
Oh sorry my bad, we don't need this. Let me remove
freddyaboulton
approved these changes
Mar 21, 2024
|
Gonna get this in to fix the CI - and I'll have another ChatInterface PR open soon |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that that the way we were calling our bash scripts was the issue:
bypasses the shebang line because when you tell the shell to use
bashexplicitly, it no longer no longer needs to read the shebang line. Therefore it ignores that-eflag that would tell the script to terminate with a 1 exit code and fail the CI.Instead, we need to execute it directly:
I've confirmed on a fork that this fixes the issue: https://github.com/abidlabs/gradio/actions/runs/8365477830/job/22903396215