Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root url resolution from x_forwarded_host headers #7787

Merged
merged 15 commits into from Mar 22, 2024
Merged

Fix root url resolution from x_forwarded_host headers #7787

merged 15 commits into from Mar 22, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Mar 21, 2024

Oversight on my part -- if we are using x_forwarded_host header to construct the root url, we should not be stripping the trailing characters belonging to the route_url.

I've added a test and the fix has been confirmed by users in #7724 and #7774

Closes: #7774
Closes: #7724

@abidlabs abidlabs changed the title logging logging root url Mar 21, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 21, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/2f1c470d3bc2357a1def1297a267669ef2f4f981/gradio-4.22.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2f1c470d3bc2357a1def1297a267669ef2f4f981#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 21, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix root url resolution from x_forwarded_host headers

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 22, 2024
@abidlabs abidlabs marked this pull request as ready for review March 22, 2024 19:44
@abidlabs abidlabs changed the title logging root url fix root url resolution from x_forwarded_host headers Mar 22, 2024
@abidlabs abidlabs changed the title fix root url resolution from x_forwarded_host headers Fix root url resolution from x_forwarded_host headers Mar 22, 2024
@abidlabs
Copy link
Member Author

Thanks @freddyaboulton for reviewing!

@abidlabs abidlabs merged commit 781678b into main Mar 22, 2024
7 checks passed
@abidlabs abidlabs deleted the log-root branch March 22, 2024 22:08
@pngwn pngwn mentioned this pull request Mar 22, 2024
@rwb-truelime
Copy link

Thanks for fixing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradio-4.22.0 broken ngrok tunneling Remaining bug from #7317 - file path resolution wrong
4 participants