New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root url resolution from x_forwarded_host
headers
#7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/2f1c470d3bc2357a1def1297a267669ef2f4f981/gradio-4.22.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2f1c470d3bc2357a1def1297a267669ef2f4f981#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
This was referenced Mar 21, 2024
abidlabs
requested review from
aliabid94,
dawoodkhan82,
freddyaboulton and
whitphx
March 22, 2024 19:52
abidlabs
changed the title
logging root url
fix root url resolution from Mar 22, 2024
x_forwarded_host
headers
abidlabs
changed the title
fix root url resolution from
Fix root url resolution from Mar 22, 2024
x_forwarded_host
headersx_forwarded_host
headers
freddyaboulton
approved these changes
Mar 22, 2024
Thanks @freddyaboulton for reviewing! |
Merged
Thanks for fixing! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight on my part -- if we are using
x_forwarded_host
header to construct the root url, we should not be stripping the trailing characters belonging to the route_url.I've added a test and the fix has been confirmed by users in #7724 and #7774
Closes: #7774
Closes: #7724