Bugfix: .. in filename throwing error while loading in output.

[shubhamofbce]

Description

We were checking if .. in file path to prevent path traversal, but we need to exclude filename while checking this otherwise it will return false if filename has dots in it. So I have updated the function to check path without filename.

Closes: #7755

🎯 PRs Should Target Issues

Not adhering to this guideline will result in the PR being closed.

[gradio-pr-bot]

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
🦄	Changes	detected!	Details

---

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/c205c1df0cff21d68e01474907e1fd6e0d36daad/gradio-4.23.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c205c1df0cff21d68e01474907e1fd6e0d36daad#subdirectory=client/python"

[gradio-pr-bot]

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
gradio	patch

• Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Bugfix: .. in filename throwing error while loading in output.

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

• Maintainers can change the version label to modify the version bump.
• If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

[shubhamofbce]

@abidlabs This is a small bugfix, and ready for review. Let me know if you have any questions.

[freddyaboulton]

Thanks @shubhamofbce for addressing comments! CC @abidlabs prior to merge

[abidlabs]

Hmm let me take a look at these tests

[abidlabs]

So the docstring for is_in_or_equal is actually inaccurate. We do have some use cases where path_1 can be a file path as well, namely the use here:

gradio/gradio/utils.py

Line 1079 in 2f12512

return any(is_in_or_equal(file_path, static_file) for static_file in static_files)

So I slightly refactored the implementation to be a little more explicit what we are testing. Also added a unit test.

[freddyaboulton]

Nice LGTM @abidlabs !

[abidlabs]

Thanks @shubhamofbce for the original PR identifying the cause of the issue and @freddyaboulton for reviewing the fix. Will merge in after CI