Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to client.view_api() in the case of default file values #7800

Merged
merged 5 commits into from Mar 23, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Mar 22, 2024

I forgot to address this comment by @freddyaboulton: #7732 (comment). This PR fixes it.

Test with:

import gradio as gr

demo = gr.Interface(
    lambda x,y:x,
    [gr.Audio("test.mp3"), gr.Number()],
    "audio"
)

_, url, _ = demo.launch(inline=False)

from gradio_client import Client

client = Client(url)

client.view_api()

@abidlabs abidlabs marked this pull request as ready for review March 22, 2024 23:15
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 22, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/04fd29dbaa36e9f59de5e8ae34cfd103c548b998/gradio-4.22.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@04fd29dbaa36e9f59de5e8ae34cfd103c548b998#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 22, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
gradio_client patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Small fix to client.view_api() in the case of default file values

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 22, 2024
@abidlabs abidlabs changed the title Small fix to client.view_api() in the case of default values Small fix to client.view_api() in the case of default file values Mar 22, 2024
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! works great for me. Shows:

Client.predict() Usage Info
---------------------------
Named API endpoints: 1

 - predict(x, y, api_name="/predict") -> output
    Parameters:
     - [Audio] x: filepath (not required, defaults to:   file("http://127.0.0.1:7860/file=/Users/aliabdalla/Documents/dev/gradio/client/python/test.mp3"))
     - [Number] y: float (required)
    Returns:
     - [Audio] output: filepath

@abidlabs
Copy link
Member Author

Thanks @aliabd!

@abidlabs abidlabs merged commit b0a3ea9 into main Mar 23, 2024
7 checks passed
@abidlabs abidlabs deleted the fix-view-api branch March 23, 2024 00:27
@pngwn pngwn mentioned this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants