New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multimodal Textbox Loading + other fixes #7848
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/a4878bcc4d8e4560b6086aae03d723c18deab7f9/gradio-4.23.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a4878bcc4d8e4560b6086aae03d723c18deab7f9#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@@ -74,7 +74,7 @@ def __init__( | |||
render: bool = True, | |||
text_align: Literal["left", "right"] | None = None, | |||
rtl: bool = False, | |||
submit_btn: str | Literal[False] = "⌲", | |||
submit_btn: str | Literal[False] = "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use None
I think? And we should mention in the docstring that if None, an svg of a send icon is used.
submit_btn: str | Literal[False] = "", | |
submit_btn: str | Literal[False] | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Looks great. Just left one suggestion on the python side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for taking care of this @dawoodkhan82 !
Ok great, let me go ahead and merge this in so that we can get the release out! |
Description
Replaces "send" emoji icon with svg.
Removed
UploadProgress
and added a progress loading animation+some other small css fixes
Closes: #7768
Closes: #7812
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh