Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the minify setting in vite.config.js which was mistakingly introduced in #6261 #7852

Merged
merged 2 commits into from Mar 27, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Mar 27, 2024

Description

Ref: https://huggingface.slack.com/archives/C055NMB0S87/p1711525308205149?thread_ts=1711089573.553429&cid=C055NMB0S87

Confirmed that pnpm --filter @gradio/app build:lite generated a minified lite.js.

@whitphx whitphx requested a review from pngwn March 27, 2024 08:29
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 27, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/964fd3b886672b2b0d731990b02bfcaf2689a715/gradio-4.23.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@964fd3b886672b2b0d731990b02bfcaf2689a715#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 27, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Revert the minify setting in vite.config.js which was mistakingly introduced in #6261

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx marked this pull request as ready for review March 27, 2024 08:35
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @whitphx!

@whitphx whitphx merged commit 72661e3 into main Mar 27, 2024
9 checks passed
@whitphx whitphx deleted the minify-build branch March 27, 2024 10:03
@pngwn pngwn mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants