New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Markdown formatting for Chatbots, MarkdownCode #7936
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/ec561f25da56d1b2bf3414c916b9069003f51215/gradio-4.25.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ec561f25da56d1b2bf3414c916b9069003f51215#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This messing up the spacing in both the data frame and the chatbot. We'll need to fix that somehow.
It would also be good to modify one of the chatbot stories to use some more complex markdown so we can catch any regressions or strangeness since the markdown code component is used in a few places.
…app/gradio into restore_prose_formatting
I fixed the extra spacing at the bottom of each markdown blob. The text size has gotten 2 points smaller in the chatbot because we use --text-md in prose (14px), instead of the usual 16px used for buttons. But I think almost all the visual changes make sense, this makes MarkdownCode look consistent with Markdown. Can you point to specific issues? Could add UI test that's more visually complex. |
Was just that bottom spacing I think. Other changes look fine to me, I only noticed when reviewing the UI tests. |
lgtm! I don't notice any breaking style changes |
…app/gradio into restore_prose_formatting
The MarkdownCode object does not format several of its Markdown elements, including headers, lists, backquotes because it doesn't use the
prose
class. Added.Before:
After: