Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure ImageEditor always draws at the correct position #7959

Merged
merged 7 commits into from Apr 15, 2024

Conversation

hrrbay
Copy link
Contributor

@hrrbay hrrbay commented Apr 8, 2024

Description

Using Examples with ImageEditor without the workaround in #6822 leads to drawing at wrong positions as discussed in #7258. This is caused because the initial layer is added before the image is uploaded. The layer therefore has wrong dimensions. The fix simply resets layers on dimension change.

Closes #7258. Closes #6822.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 8, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/77eed46c1b7f1ec18e31aab53a6613fa5ead0a6d/gradio-4.26.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@77eed46c1b7f1ec18e31aab53a6613fa5ead0a6d#subdirectory=client/python"

@pngwn
Copy link
Member

pngwn commented Apr 8, 2024

Thanks for this PR! I'll take a look today!

Does this fix #6822 as well?

@hrrbay
Copy link
Contributor Author

hrrbay commented Apr 8, 2024

Does this fix #6822 as well?

Yes, the non-working code snippet provided in #6822 now works as expected for me.

@pngwn
Copy link
Member

pngwn commented Apr 8, 2024

Awesome thanks. Will test and review shortly!

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 8, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/imageeditor patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

ensure ImageEditor always draws at the correct position

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hrrbay
Copy link
Contributor Author

hrrbay commented Apr 8, 2024

I have noticed that the intial change breaks the use case of initializing layers to specific values when using a dict as value for an example as the layer might simply be removed. One way to fix this would be to only reset the layers on the frontend if some layer does not match the new dimensions as done in 4b9686a.

@pngwn pngwn changed the title Fix ImageEditor drawing at wrong position. ensure ImageEditor always draws at the correct position Apr 15, 2024
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for both of the linked cases as far as I can tell! Thanks so much @hrrbay!

@pngwn pngwn enabled auto-merge (squash) April 15, 2024 21:46
@pngwn pngwn merged commit 2a5cb97 into gradio-app:main Apr 15, 2024
8 checks passed
@pngwn pngwn mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants