Fix heartbeat in the js client to be Lite compatible #7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitphx
commented
Apr 9, 2024
client/js/src/client.ts
Outdated
| `${config.root}/heartbeat/${session_hash}` | ||
| ); | ||
| const heartbeat = EventSource_factory(heartbeat_url); |
There was a problem hiding this comment.
btw, this heartbeat variable is not used after the declaration here. Is it ok?
There was a problem hiding this comment.
I don't think we have to assign it to a variable since we just have to connect to it, we don't have to parse the messages on this channel.
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/26fd6daa87d3c48e48d6481c197a2b88fb2b5738/gradio-4.26.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@26fd6daa87d3c48e48d6481c197a2b88fb2b5738#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
approved these changes
Apr 9, 2024
freddyaboulton
added
t: fix
|
Just tagged this to be a patch instead of a feature in the changelog |
Merged
freddyaboulton
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Fix heartbeat in the js client to be Lite compatible * add changeset * add changeset * Stop assigning the EventSource instance to a variable at heartbeat --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes this error