Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_progress prop to Upload Component to bring back upload progress animation #8002

Merged
merged 5 commits into from Apr 11, 2024

Conversation

freddyaboulton
Copy link
Collaborator

Description

Closes #7988

We want a custom progress animation for MultimodalTextbox than we do for the other components uploads. So I'm adding a show_progress prop to be able to better distinguish between the two cases.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@freddyaboulton freddyaboulton added t: fix A change that implements a fix v: patch A change that requires a patch release labels Apr 11, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 11, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/698e99b64bab57a12c8b8898a7f362fe43282813/gradio-4.26.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@698e99b64bab57a12c8b8898a7f362fe43282813#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 11, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/multimodaltextbox patch
@gradio/upload patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add show_progress prop to Upload Component to bring back upload progress animation

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review April 11, 2024 16:43
@abidlabs
Copy link
Member

LGTM @freddyaboulton! Tested works great

@abidlabs
Copy link
Member

Going to merge this in so that we can get tests passing on other PRs

@abidlabs abidlabs merged commit 8903415 into main Apr 11, 2024
8 checks passed
@abidlabs abidlabs deleted the fix-upload-progress branch April 11, 2024 22:30
@pngwn pngwn mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload loading indicator disappeared from gr.Image on 4.26.0
3 participants