New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an explicit dependency of urllib3~=2.0
and update processing_utils.save_url_to_cache
to use urllib3
for Lite support
#8011
Conversation
…save_url_to_cache` to use `urllib3` for Lite support
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/3b1dfba9c550749e913dff57799d31a57556fb32/gradio-4.26.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3b1dfba9c550749e913dff57799d31a57556fb32#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, everything works great! Should be good to merge @whitphx pending the suggestion above
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
urllib3
and update processing_utils.save_url_to_cache
to use urllib3
for Lite supporturllib3>=2.0
and update processing_utils.save_url_to_cache
to use urllib3
for Lite support
Going to upgrade this to a minor since we are updating our requirements. We have a test that is failing b/c botocore does not support urllib 2 but I'm going to see if we can upgrade the version of botocore to fix this |
urllib3>=2.0
and update processing_utils.save_url_to_cache
to use urllib3
for Lite supporturllib3~=2.0
and update processing_utils.save_url_to_cache
to use urllib3
for Lite support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about async_save_url_to_cache
? But this change looks good @whitphx
Oh good catch @freddyaboulton! @whitphx, as @freddyaboulton pointed out, |
Thank you @abidlabs @freddyaboulton ! I missed it. |
Made a PR: #8026 |
Description
Closes: #6837
processing_utils.save_url_to_cache()
to useurllib3
to work on Lite as well.urllib3
, add it inrequirements.txt
explicitly.>=2.2.0
) was not necessary because Pyodide shipsurllib==2.1.0
which works on Pyodide andurllib>=2.2.0
supports Pyodide on its end.With this PR, apps like below can work that uses
examples
with URLs.