Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that show_copy_button in gr.Textbox is not visible when show_label=False #8012

Merged

Conversation

lappemic
Copy link
Contributor

@lappemic lappemic commented Apr 12, 2024

Description

As discussed in the issue mentioned below, it was not mirrored in the docstring of gr.Textbox that show_copy_button is not visible when show_label=False. This PR adds a short Note about this after the already existing Parameters doc.

Closes: #7717 - @abidlabs

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

…_label=False

Remove dict_to_dataclass since its not used
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 12, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/357ae620a8038f3ba84121dfea70a27ce6e16c64/gradio-4.26.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@357ae620a8038f3ba84121dfea70a27ce6e16c64#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 12, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Document that show_copy_button in gr.Textbox is not visible when show_label=False

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lappemic

@abidlabs abidlabs added the v: patch A change that requires a patch release label Apr 12, 2024
@abidlabs abidlabs enabled auto-merge (squash) April 12, 2024 15:59
gradio-pr-bot and others added 3 commits April 12, 2024 16:00
@abidlabs abidlabs merged commit 299c87c into gradio-app:main Apr 12, 2024
7 checks passed
@pngwn pngwn mentioned this pull request Apr 12, 2024
@lappemic lappemic deleted the 7717-document-show_copy_button-in-Textbox branch April 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that show_copy_button in gr.Textbox is not visible when show_label=False
4 participants