Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace version for code in _website #8189

Merged
merged 5 commits into from
May 1, 2024
Merged

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented May 1, 2024

Uses workspace for @gradio/code in the _website package.json instead of a pinned version. Removes the circular import from js/preview/test/test/frontend that was causing the issue. Also changes the version of postcss to use pnpm 9.0.0

@aliabd aliabd marked this pull request as draft May 1, 2024 20:07
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 1, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/90d349fd2d7f2d800882a6a68bb13aeeccad1a5d/gradio-4.28.3-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@90d349fd2d7f2d800882a6a68bb13aeeccad1a5d#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 1, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
gradio_test patch
website patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Use workspace version for code in _website

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@aliabd aliabd marked this pull request as ready for review May 1, 2024 20:33
@aliabd aliabd requested a review from pngwn May 1, 2024 20:33
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch. Thanks for figuring this out @aliabd!

@aliabd aliabd merged commit 68dcae5 into main May 1, 2024
9 checks passed
@aliabd aliabd deleted the aliabd/code-workspace branch May 1, 2024 21:17
freddyaboulton pushed a commit that referenced this pull request May 2, 2024
* workspace

* add changeset

* remove circular import from preview

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
@pngwn pngwn mentioned this pull request May 3, 2024
dawoodkhan82 pushed a commit that referenced this pull request May 6, 2024
* workspace

* add changeset

* remove circular import from preview

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants