-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing keyword args to data
in JS client
#8197
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/bdd46e939181c30b67e55df1ce696932ab662b19/gradio-4.29.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@bdd46e939181c30b67e55df1ce696932ab662b19#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
todo: need to update codesnippet.svelte |
… into js-client-kwargs
data
in JS clientdata
in JS client
… into js-client-kwargs
… into js-client-kwargs
… into js-client-kwargs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one small comment but everything else looks great + works as expected!
Thanks @hannahblair!
Nice @hannahblair! Just 2 nits with regards to the code snippets: ![]()
Matching the Python code snippet and parameter table: ![]()
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good, will file another issue for the API recorder because it is broken in the release.
Description
This PR adds support for passing keyword arguments as well as positional args to the
data
param in the JS client. This is backwards compatible, so the two usages will work:Also adds unit tests.
The
CodeSnippet.svelte
API usage has been updated, which you can see here: https://huggingface.co/spaces/hmb/test_argsCloses: #7831
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh