Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multimodal textbox placeholder #8455

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Fix multimodal textbox placeholder #8455

merged 5 commits into from
Jun 4, 2024

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Fixes placeholder spacing when submit is clicked.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 4, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/d8164a21eb1bc7dd332549c16dfd72aa553eb499/gradio-4.32.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d8164a21eb1bc7dd332549c16dfd72aa553eb499#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/d8164a21eb1bc7dd332549c16dfd72aa553eb499/gradio-client-0.20.1.tgz

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 4, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/multimodaltextbox patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix multimodal textbox placeholder

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jun 4, 2024
@abidlabs
Copy link
Member

abidlabs commented Jun 4, 2024

This fixes the issue in the default Gradio theme, but it seems that now the positioning of the multimodal textbox icons in the other themes is off again, reverting the fixes in: #8369. E.g. monochrome:

image

Can you confirm that a standard gr.ChatInterface(multimodal=True) works with all 5 of the built-in themes?

import gradio as gr

gr.ChatInterface(lambda x,y:x["text"], multimodal=True, theme="monochrome").launch()

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @dawoodkhan82 looks good in all of the demos I tested!

@abidlabs
Copy link
Member

abidlabs commented Jun 4, 2024

I'm going to auto-merge this so that @aliabid94 can do a release if needed

@abidlabs abidlabs enabled auto-merge (squash) June 4, 2024 22:17
@abidlabs abidlabs merged commit a970589 into main Jun 4, 2024
7 of 8 checks passed
@abidlabs abidlabs deleted the placeholder branch June 4, 2024 22:25
@pngwn pngwn mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants