Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flaky state change test #8469

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fixes flaky state change test #8469

merged 1 commit into from
Jun 6, 2024

Conversation

aliabid94
Copy link
Collaborator

basically needed to have some UI change in response to a click so that the test would wait for the response in an expect. otherwise would "run too fast".

@aliabid94 aliabid94 requested a review from pngwn June 5, 2024 22:13
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 5, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/8c90972179f51b4fc767e70667c16fe87a86b94e/gradio-4.33.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@8c90972179f51b4fc767e70667c16fe87a86b94e#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/8c90972179f51b4fc767e70667c16fe87a86b94e/gradio-client-0.20.1.tgz

@gradio-pr-bot
Copy link
Contributor

🦄 no changes detected

This Pull Request does not include changes to any packages.

__No changes detected. __

  • Maintainers can select this checkbox to manually select packages to update.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can create the changelog file directly.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks @aliabid94!

@pngwn pngwn merged commit 8c18114 into main Jun 6, 2024
8 checks passed
@pngwn pngwn deleted the fix-state-change-test branch June 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants