Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of api recorder #8473

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Improve design of api recorder #8473

merged 9 commits into from
Jun 6, 2024

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jun 6, 2024

Just makes the buttons better and has a better recording feel.

Screen.Recording.2024-06-05.at.10.18.59.PM.mov
Screen.Recording.2024-06-05.at.10.20.16.PM.mov

Also fixes up the banner.
Screen Shot 2024-06-05 at 10 22 12 PM
vs
Screen Shot 2024-06-05 at 10 22 28 PM

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 6, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/93c1a4d540c9ab693b1194555e96a081983ceef4/gradio-4.33.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@93c1a4d540c9ab693b1194555e96a081983ceef4#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/93c1a4d540c9ab693b1194555e96a081983ceef4/gradio-client-0.20.1.tgz

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 6, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve design of api recorder

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@aliabd aliabd requested a review from abidlabs June 6, 2024 05:23
@abidlabs
Copy link
Member

abidlabs commented Jun 6, 2024

Beautiful @aliabd! I'll just fix the functional test and then this should be good to merge

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jun 6, 2024
@abidlabs abidlabs enabled auto-merge (squash) June 6, 2024 12:42
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Time to update the recordings in the slides

@abidlabs abidlabs merged commit 8ca93d4 into main Jun 6, 2024
8 checks passed
@abidlabs abidlabs deleted the aliabd/api-recorder-design branch June 6, 2024 12:55
This was referenced Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants